Skip to content

OCPBUGS-57841 updated two istio modules #95996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wgabor0427
Copy link
Contributor

@wgabor0427 wgabor0427 commented Jul 11, 2025

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 11, 2025

Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2025
@lunarwhite
Copy link
Member

/cc @bharath-b-rh
Just FYI

@openshift-ci openshift-ci bot requested a review from bharath-b-rh July 14, 2025 02:41
@bharath-b-rh
Copy link

/lgtm

@wgabor0427
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 14, 2025
@stevsmit stevsmit added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 15, 2025
@stevsmit stevsmit added this to the Continuous Release milestone Jul 15, 2025
Copy link
Member

@stevsmit stevsmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment.

+
[source,terminal]
----
$ oc new-project <istio_csr_project_name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you changed the name of the project to <istio_project_name> below, should you also change it here?

Suggested change
$ oc new-project <istio_csr_project_name>
$ oc new-project <istio_project_name>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevsmit This was moved out of this document and put in the installation document.

@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 15, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
Copy link

openshift-ci bot commented Jul 15, 2025

New changes are detected. LGTM label has been removed.

@wgabor0427
Copy link
Contributor Author

wgabor0427 commented Jul 15, 2025

@stevsmit Still working on this so don't merge yet.

Copy link

openshift-ci bot commented Jul 15, 2025

@wgabor0427: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wgabor0427
Copy link
Contributor Author

@stevsmit This is ready for merge. Thanks.

@lunarwhite
Copy link
Member

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants