-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS-57841 updated two istio modules #95996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Tue Jul 15 16:20:17 - Prow CI generated the docs preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @bharath-b-rh |
/lgtm |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment.
+ | ||
[source,terminal] | ||
---- | ||
$ oc new-project <istio_csr_project_name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because you changed the name of the project to <istio_project_name> below, should you also change it here?
$ oc new-project <istio_csr_project_name> | |
$ oc new-project <istio_project_name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevsmit This was moved out of this document and put in the installation document.
d185e05
to
2254e99
Compare
New changes are detected. LGTM label has been removed. |
@stevsmit Still working on this so don't merge yet. |
2254e99
to
af3ae84
Compare
@wgabor0427: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@stevsmit This is ready for merge. Thanks. |
/label merge-review-needed |
Version(s):
4.14+
Issue:
https://issues.redhat.com/browse/OCPBUGS-57841
Link to docs preview:
https://95996--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/cert_manager_operator/cert-manager-operator-integrating-istio.html
QE review:
Additional information: